Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make protodoc.bzl compatible with Bazel 0.26+ #7120

Closed
lizan opened this issue May 31, 2019 · 0 comments · Fixed by #7167
Closed

Make protodoc.bzl compatible with Bazel 0.26+ #7120

lizan opened this issue May 31, 2019 · 0 comments · Fixed by #7167
Labels
area/build tech debt

Comments

@lizan
Copy link
Member

lizan commented May 31, 2019

Description:
Remove --incompatible_depset_union=false from docs/build.sh added in #6866.

Relevant Links:
See recommends in https://docs.bazel.build/versions/master/skylark/depsets.html
@lizan lizan mentioned this issue Jun 4, 2019
Merged
htuch pushed a commit that referenced this issue Jun 5, 2019
@lizan @htuch
docs: fix protodoc depset calculation (#7167)
49b2e21 
Fix for incompatible bazel flags.

Risk Level: Low
Testing: CI
Docs Changes: N/A
Release Notes: N/A

Fixes #7120

Signed-off-by: Lizan Zhou <lizan@tetrate.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/build tech debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs: fix protodoc depset calculation lizan/envoy
1 participant
@lizan