Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup: followup cleanup for #7037 #7097

Merged
merged 2 commits into from
May 29, 2019
Merged

Conversation

eziskind
Copy link
Contributor

Description: remove commented-out code that I left by mistake from a previous PR
Risk Level: low
Testing: unit tests

Signed-off-by: Elisha Ziskind eziskind@google.com

Signed-off-by: Elisha Ziskind <eziskind@google.com>
mattklein123
mattklein123 previously approved these changes May 29, 2019
Copy link
Member

@mattklein123 mattklein123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@mattklein123 mattklein123 self-assigned this May 29, 2019
Signed-off-by: Elisha Ziskind <eziskind@google.com>
@eziskind eziskind changed the title cleanup: remove commented-out code cleanup: followup cleanup for #7037 May 29, 2019
@eziskind
Copy link
Contributor Author

Also fixed format which was broken by the new rule to disallow absl::make_unique

@mattklein123 mattklein123 merged commit 9f1177d into envoyproxy:master May 29, 2019
@eziskind eziskind deleted the cleanup branch May 29, 2019 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants