Fix heap-use-after-free error when shutting down envoy. #758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The HotRestart holds a socket event for the domain socket used for admin purpose, it need to be deleted before the envoy server gets deleted, as the envoy server own the event_base and which already deleted the registered events with the event_base_free().
include/envoy/server/hot_restart.h
Outdated
| @@ -65,6 +65,11 @@ class HotRestart { | |||
| virtual void terminateParent() PURE; | |||
|
|
|||
| /** | |||
| * Shutdown admin processing in the current process. | |||
| */ | |||
| virtual void shutdownAdmin() PURE; | |||
There was a problem hiding this comment.
nit: This doesn't really have anything to do with admin. Can we just call this shutdown() ?
mattklein123
approved these changes
Apr 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The HotRestartImpl holds a socket event of the domain socket for admin purpose. It needs to be deleted before the envoy server gets deleted, as the envoy server owns the event_base which already been deleted in the destructor by the event_base_free().
Also, the envoy server needs the HotRestartImpl to record stats, so the HotRestartImpl cannot be deleted before clean up the stats recorders in the envoy server.