Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix custom header example #7806

Merged

Conversation

christianladron
Copy link
Contributor

@christianladron christianladron commented Aug 1, 2019

Description:
The example shows the request_headers_to_add in the RouteAction, and this should be in the Route

Risk Level: Low
Testing: N/A
Docs Changes: This is a doc change
Release Notes: N/A

Christian Ladrón de Guevara Reyes christian@datank.ai

The example shows the request_headers_to_add in the RouteAction, and this should be in the Route

Signed-off-by: Christian Ladrón de Guevara Reyes <christian@datank.ai>
Copy link
Member

@dio dio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! Yes, this (setting request_header_to_add to RouteAction) is deprecated since 1.8.0.

@mattklein123 mattklein123 merged commit 95a2b26 into envoyproxy:master Aug 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants