Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix flake in http_subset_integration_test #8655

Merged

Conversation

zuercher
Copy link
Member

The RANDOM and LEAST_REQUEST load balancer policies randomly choose hosts
and 10 iterations isn't enough to guarantee they'll choose both hosts in
the subset.

Risk Level: low, test only
Testing: fixes tests
Docs Changes: n/a
Release Notes: n/a
Fixes: #8643

Signed-off-by: Stephan Zuercher zuercher@gmail.com

The RANDOM and LEAST_REQUEST load balancer policies randomly choose hosts
and 10 iterations isn't enough to guarantee they'll choose both hosts in
the subset.

Risk Level: low, test only
Testing: fixes tests
Docs Changes: n/a
Release Notes: n/a
Fixes: envoyproxy#8643

Signed-off-by: Stephan Zuercher <zuercher@gmail.com>
@lizan lizan merged commit 87d496d into envoyproxy:master Oct 18, 2019
@zuercher zuercher deleted the zuercher_fix_http_subset_integration_flake branch October 18, 2019 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SubsetCompatibleLoadBalancers/HttpSubsetLbIntegrationTest.SubsetLoadBalancer/LEASTREQUEST flaked
2 participants