support websocket

[qicz]

Description:

Describe the desired behavior, what scenario it enables and how it
would be used.

[optional Relevant Links:]

Any extra documentation required to understand the issue.

[Xunzhuo]

Plz provide more infos, then we can have a deep understanding on the background of this issue.

[qicz]

the current eg version cannot support WebSocket requests that are missing upgrade configs for this. just this. @Xunzhuo

[danehans]

Moving to the backlog since kubernetes-sigs/gateway-api#205 must be resolved before this feature can be implemented.

[zhshw]

@danehans HTTPRoute add annations ,like this can imp websocket、timeout、retry......
HTTPRoute.Annotations["envoy-gateway/upgrade-websocket"]

routeAction setting UpgradeConfig
if isWebsocket { routeAction.UpgradeConfigs = []*route.RouteAction_UpgradeConfig{{ UpgradeType: "websocket", }} }

[arkodg]

@zhshw annotations lack structure needed to correctly validate intent, we prefer adding support using explicit fields instead

[zhshw]

@arkodg
annotations are the simplest and most practical way to quickly implement useful functions. Annotation content can be yaml or json，Disagree with annotations lack structure

Backendref serivce（single OR multi?）can be an associated Envoy route configuration . Use the Envoy xds route field as a richer configuration

The intermediate field definition will lose many useful configurations. Moreover, there is a lack of validation, design documents and usage documents and the development cycle is long

Use xds route configuration fragments (annotations) or associated complete route configuration (configmap, crd), they are all better implementation

Summary：

• No lose many useful configurations
• No risk of design failure （ intermediate field）
• Quickly implement
• Configure it by using the envoy document （helpful）

[luofish]

@arkodg it's a feature request, maybe we can use anno instead before explicit fields be designed

[crain-cn]

@arkodg it's a feature request, maybe we can use anno instead before explicit fields be designed

[arkodg]

it looks like envoy allows web socket upgrade https://www.envoyproxy.io/docs/envoy/latest/start/sandboxes/websocket which should be easy to achieve using this config in HCM

upgrade_configs:
          - upgrade_type: websocket

and it looks like istio enables this by default, so leaning towards enabling this by default for HTTP 1.1 (HTTPRoute), upgrades are disallowed for HTTP 2.0 (GRPCRoute)