Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skip casting to string in caller & callee in test #1058

Merged
merged 1 commit into from
Feb 17, 2023

Conversation

arkodg
Copy link
Contributor

@arkodg arkodg commented Feb 17, 2023

No description provided.

Signed-off-by: Arko Dasgupta <arko@tetrate.io>
@arkodg arkodg requested a review from a team as a code owner February 17, 2023 22:24
@codecov-commenter
Copy link

Codecov Report

Merging #1058 (be329b2) into main (c4d57fb) will increase coverage by 0.13%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main    #1058      +/-   ##
==========================================
+ Coverage   64.70%   64.84%   +0.13%     
==========================================
  Files          67       67              
  Lines        8730     8730              
==========================================
+ Hits         5649     5661      +12     
+ Misses       2706     2697       -9     
+ Partials      375      372       -3     
Impacted Files Coverage Δ
internal/provider/kubernetes/controller.go 51.24% <0.00%> (+0.67%) ⬆️
internal/provider/kubernetes/routes.go 33.94% <0.00%> (+0.91%) ⬆️
internal/provider/kubernetes/helpers.go 81.75% <0.00%> (+2.02%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@arkodg arkodg requested a review from skriss February 17, 2023 22:51
@arkodg arkodg merged commit d6b4402 into envoyproxy:main Feb 17, 2023
@arkodg arkodg deleted the fix-str-cast branch February 17, 2023 23:18
@qicz qicz mentioned this pull request Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants