feat: add namespaced all proxies config dump support #1082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @zirain |
Xunzhuo
changed the title
Codecov Report
@@ Coverage Diff @@
## main #1082 +/- ##
==========================================
- Coverage 61.49% 61.39% -0.10%
==========================================
Files 79 79
Lines 11439 11465 +26
==========================================
+ Hits 7034 7039 +5
- Misses 3944 3966 +22
+ Partials 461 460 -1
|
|
cc @arkodg, please take a look too. |
arkodg
reviewed
Feb 28, 2023
|
When replicas is 1 
|
|
When replicas is 2 
|
Signed-off-by: bitliu <bitliu@tencent.com>
Xunzhuo
requested review from
a team,
zhaohuabing,
chauhanshubham and
qicz
and removed request for
a team
qicz
reviewed
May 29, 2023
| @@ -113,10 +113,28 @@ func retrieveConfigDump(args []string, includeEds bool, configType envoyConfigTy | |||
| // fetchRunningEnvoyPods gets the Pods, either based on the NamespacedName or the labelSelectors. | |||
| // It further filters out only those Pods that are in "Running" state. | |||
| // labelSelectors, if provided, take precedence over the pod NamespacedName. | |||
| func fetchRunningEnvoyPods(c kube.CLIClient, nn types.NamespacedName, labelSelectors []string) ([]types.NamespacedName, error) { | |||
| func fetchRunningEnvoyPods(c kube.CLIClient, nn types.NamespacedName, labelSelectors []string, allNamespaces bool) ([]types.NamespacedName, error) { | |||
There was a problem hiding this comment.
IMO nn is not readable , prefer name or namespacedName
There was a problem hiding this comment.
I did not change the previous vars, I think this is nit and not a blocker for this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref: #1069