Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

code polish. #1087

Merged
merged 2 commits into from
Mar 2, 2023
Merged

code polish. #1087

merged 2 commits into from
Mar 2, 2023

Conversation

qicz
Copy link
Member

@qicz qicz commented Mar 1, 2023

  • refactor go-control-panel ref with version
  • refactor exceptXXName to exceptResourceHashedName
  • other code polish

@qicz qicz requested a review from a team as a code owner March 1, 2023 02:47
@codecov-commenter
Copy link

codecov-commenter commented Mar 1, 2023

Codecov Report

Merging #1087 (8b584f5) into main (a23cd3e) will decrease coverage by 0.32%.
The diff coverage is 83.46%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main    #1087      +/-   ##
==========================================
- Coverage   62.82%   62.51%   -0.32%     
==========================================
  Files          72       72              
  Lines        9394     9414      +20     
==========================================
- Hits         5902     5885      -17     
- Misses       3090     3121      +31     
- Partials      402      408       +6     
Impacted Files Coverage Δ
internal/cmd/egctl/config.go 6.69% <0.00%> (ø)
internal/gatewayapi/contexts.go 76.22% <ø> (ø)
internal/gatewayapi/listener.go 100.00% <ø> (ø)
internal/provider/kubernetes/controller.go 49.32% <0.00%> (-2.61%) ⬇️
internal/status/gateway.go 0.00% <0.00%> (ø)
internal/xds/server/runner/runner.go 21.56% <0.00%> (ø)
internal/xds/types/resourceversiontable.go 62.85% <0.00%> (ø)
internal/xds/translator/route.go 81.08% <62.50%> (ø)
internal/cmd/egctl/translate.go 70.27% <66.66%> (+2.30%) ⬆️
internal/xds/translator/authentication.go 64.31% <85.71%> (ø)
... and 16 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

internal/ir/xds.go Outdated Show resolved Hide resolved
internal/gatewayapi/contexts.go Outdated Show resolved Hide resolved
internal/gatewayapi/contexts.go Outdated Show resolved Hide resolved
@arkodg
Copy link
Contributor

arkodg commented Mar 1, 2023

thanks @qicz , did you do this manually or using some tool :)

@qicz
Copy link
Member Author

qicz commented Mar 1, 2023

thanks @qicz , did you do this manually or using some tool :)

ok. all review cases have been resolved.

@qicz qicz requested a review from arkodg March 1, 2023 03:31
Signed-off-by: qicz <qiczzhu@gmail.com>
Xunzhuo
Xunzhuo previously approved these changes Mar 1, 2023
Copy link
Member

@Xunzhuo Xunzhuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, need another look from @arkodg

Signed-off-by: qicz <qiczzhu@gmail.com>
@qicz
Copy link
Member Author

qicz commented Mar 2, 2023

@arkodg I resolved all, pls review again, thanks

Copy link
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks !

@arkodg arkodg merged commit d530bb9 into envoyproxy:main Mar 2, 2023
@qicz qicz deleted the code-polish branch March 2, 2023 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants