-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
code polish. #1087
code polish. #1087
Conversation
qicz
commented
Mar 1, 2023
•
edited
edited
- refactor go-control-panel ref with version
- refactor exceptXXName to exceptResourceHashedName
- other code polish
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #1087 +/- ##
==========================================
- Coverage 62.82% 62.51% -0.32%
==========================================
Files 72 72
Lines 9394 9414 +20
==========================================
- Hits 5902 5885 -17
- Misses 3090 3121 +31
- Partials 402 408 +6
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
thanks @qicz , did you do this manually or using some tool :) |
ok. all review cases have been resolved. |
Signed-off-by: qicz <qiczzhu@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, need another look from @arkodg
@arkodg I resolved all, pls review again, thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks !