auto generate extensions.go #1126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: hejianpeng <hejianpeng2@huawei.com>
arkodg
reviewed
Mar 10, 2023
arkodg
reviewed
Mar 10, 2023
arkodg
reviewed
Mar 10, 2023
| @@ -67,6 +67,11 @@ go.mod.lint: | |||
| $(call log, "Go module looks clean!"); \ | |||
| fi | |||
|
|
|||
| .PHONY: go.generate | |||
| go.generate: ## Generate code from templates | |||
There was a problem hiding this comment.
needs to be linked to make generate
There was a problem hiding this comment.
also needs to be linked to make gen-check
There was a problem hiding this comment.
IMO, linked to gen-check is enough.
arkodg
reviewed
Mar 10, 2023
| //go:generate sh -c "echo '// the root of the repo.\n' >> extensions.gen.go" | ||
| //go:generate sh -c "echo '// GENERATED FILE -- DO NOT EDIT\n' >> extensions.gen.go" | ||
| //go:generate sh -c "echo 'package extensions\n\nimport (' >> extensions.gen.go" | ||
| //go:generate sh -c "go list github.com/envoyproxy/go-control-plane/... | grep 'v[2-9]' | grep -v /pkg/ | xargs -I{} echo '\t_ \"{}\"' >> extensions.gen.go" |
There was a problem hiding this comment.
🚀 thanks for automating this !
Signed-off-by: hejianpeng <hejianpeng2@huawei.com>
Signed-off-by: hejianpeng <hejianpeng2@huawei.com>
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #1126 +/- ##
==========================================
- Coverage 62.72% 62.67% -0.06%
==========================================
Files 72 72
Lines 9527 9527
==========================================
- Hits 5976 5971 -5
- Misses 3138 3143 +5
Partials 413 413 see 2 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
arkodg
reviewed
Mar 11, 2023
Signed-off-by: hejianpeng <hejianpeng2@huawei.com>
arkodg
approved these changes
Mar 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #1116