feat: set tcp proxy listener buffer #1306
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1306 +/- ##
==========================================
- Coverage 61.88% 61.83% -0.06%
==========================================
Files 85 85
Lines 10852 10853 +1
==========================================
- Hits 6716 6711 -5
- Misses 3692 3697 +5
- Partials 444 445 +1
... and 2 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
internal/xds/translator/listener.go
Outdated
| @@ -39,6 +40,7 @@ func buildXdsTCPListener(name, address string, port uint32) *listenerv3.Listener | |||
| Filter: listenerAccessLogFilter, | |||
| }, | |||
| }, | |||
| PerConnectionBufferLimitBytes: wrapperspb.UInt32(32768), | |||
There was a problem hiding this comment.
should EG support to custom this?
There was a problem hiding this comment.
lets raise a issue for this ? #24 is always a back up option
There was a problem hiding this comment.
If so, we need to add new apis in envoyproxy too, let us keep it in this way, unless someone requests for it.
internal/xds/translator/listener.go
Outdated
| @@ -39,6 +40,7 @@ func buildXdsTCPListener(name, address string, port uint32) *listenerv3.Listener | |||
| Filter: listenerAccessLogFilter, | |||
| }, | |||
| }, | |||
| PerConnectionBufferLimitBytes: wrapperspb.UInt32(32768), | |||
There was a problem hiding this comment.
would be great if this is a magic number const, with a link to https://www.envoyproxy.io/docs/envoy/latest/api-v3/config/listener/v3/listener.proto#envoy-v3-api-field-config-listener-v3-listener-per-connection-buffer-limit-bytes
Signed-off-by: bitliu <bitliu@tencent.com>
Part of: #1048