Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure Envoy recommended edge proxy settings are set by default #1048

Open
13 of 15 tasks
arkodg opened this issue Feb 15, 2023 · 15 comments
Open
13 of 15 tasks

Ensure Envoy recommended edge proxy settings are set by default #1048

arkodg opened this issue Feb 15, 2023 · 15 comments
Assignees
Labels
kind/enhancement New feature or request no stalebot
Milestone

Comments

@arkodg
Copy link
Contributor

arkodg commented Feb 15, 2023

Description:
Ensure we are setting Envoy Edge Proxy settings by default to the values specified in https://www.envoyproxy.io/docs/envoy/latest/configuration/best_practices/edge#configuring-envoy-as-an-edge-proxy

TCP proxies

HTTP proxies:

If Envoy is configured with RBAC filter or makes route selection based on URL path it is recommended to enable the following path normalization options to minimize probability of path confusion vulnerabilities. Path confusion vulnerabilities occur when parties participating in request use different path representations.

@arkodg arkodg added kind/enhancement New feature or request help wanted Extra attention is needed labels Feb 15, 2023
@arkodg arkodg added this to the Backlog milestone Feb 15, 2023
@arkodg arkodg changed the title Ensure Envoy recommended Edge Proxy settings are set by default Ensure Envoy recommended edge proxy settings are set by default Feb 15, 2023
@arkodg arkodg modified the milestones: Backlog, 0.5.0-rc1 Feb 15, 2023
@Xunzhuo Xunzhuo self-assigned this Feb 16, 2023
@Xunzhuo
Copy link
Member

Xunzhuo commented Feb 16, 2023

I will work on it.

@arkodg arkodg removed the help wanted Extra attention is needed label Feb 17, 2023
@github-actions github-actions bot added the stale label Apr 14, 2023
@envoyproxy envoyproxy deleted a comment from github-actions bot Apr 14, 2023
@Xunzhuo Xunzhuo added no stalebot and removed stale labels Apr 14, 2023
@tanujd11
Copy link
Member

Hey @Xunzhuo, I would also like to help out with this issue if it's fine with you. I can take up a few of the tasks.

@Xunzhuo
Copy link
Member

Xunzhuo commented Apr 21, 2023

@tanujd11 can you tell which subtasks you want to assign?

@tanujd11
Copy link
Member

tanujd11 commented Apr 21, 2023

@Xunzhuo I could start from bottom with if it works for you

@Xunzhuo
Copy link
Member

Xunzhuo commented Apr 23, 2023

Sure @tanujd11

@tanujd11
Copy link
Member

Hey @Xunzhuo , I shall start working on the HTTP proxy tasks. Have you picked any so we don't duplicate the work?

@Xunzhuo
Copy link
Member

Xunzhuo commented Apr 27, 2023

Feel free please @tanujd11

@tanujd11
Copy link
Member

tanujd11 commented May 8, 2023

@arkodg, EG don't support Http3 yet. So I am skipping the h3 connection settings. We can set it once #422 is done.

@arkodg
Copy link
Contributor Author

arkodg commented Jun 13, 2023

hey @tanujd11 checking in to see if you plan on working on the remaining sub tasks before v0.5.0 releases (end July 2023), else will move this issue into the backlog, thanks in advance !

@tanujd11
Copy link
Member

Hey @arkodg, I will take a look at it on the weekend.

@arkodg
Copy link
Contributor Author

arkodg commented Jun 15, 2023

awesome thanks !

@arkodg
Copy link
Contributor Author

arkodg commented Jul 12, 2023

hey @tanujd11 still planning on working on this in the next few weeks ?
if not, will move this into the the next v0.6.0 release milestone, thanks

@tanujd11
Copy link
Member

Hey @arkodg , Ya I was not able to find time. Could you please move it over to next release. Thanks

@arkodg
Copy link
Contributor Author

arkodg commented Jul 18, 2023

thanks for the update @tanujd11 , moving this to v0.6.0-rc1

@shahar-h
Copy link
Contributor

shahar-h commented Apr 7, 2024

@arkodg overload_manager can be checked as it is completed with #3082.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request no stalebot
Projects
None yet
Development

No branches or pull requests

4 participants