New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update k8s.io to v0.27.1 #1326
Conversation
Signed-off-by: hejianpeng <hejianpeng2@huawei.com>
Codecov Report
@@ Coverage Diff @@
## main #1326 +/- ##
==========================================
- Coverage 61.81% 61.74% -0.07%
==========================================
Files 85 85
Lines 10854 10854
==========================================
- Hits 6709 6702 -7
- Misses 3700 3706 +6
- Partials 445 446 +1
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
@@ -1204,7 +1204,7 @@ func (r *gatewayAPIReconciler) watchResources(ctx context.Context, mgr manager.M | |||
return nil | |||
} | |||
|
|||
func (r *gatewayAPIReconciler) enqueueManagedClass(obj client.Object) []reconcile.Request { | |||
func (r *gatewayAPIReconciler) enqueueManagedClass(_ context.Context, obj client.Object) []reconcile.Request { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
curious why this API signature had to change ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
charts/gateway-helm/crds/generated/config.gateway.envoyproxy.io_envoyproxies.yaml
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
What type of PR is this?
What this PR does / why we need it:
chore: update k8s.io to v0.27.1
Which issue(s) this PR fixes:
Fixes #