feat: set path normalization settings #1341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tanujd11 <dwiveditanuj41@gmail.com>
|
@Xunzhuo could you please rerun the CI. I guess there was some issue in uploading the Codecov report in the last run. Thanks |
Codecov Report
@@ Coverage Diff @@
## main #1341 +/- ##
==========================================
- Coverage 61.84% 61.84% -0.01%
==========================================
Files 76 76
Lines 10718 10723 +5
==========================================
+ Hits 6629 6632 +3
- Misses 3644 3645 +1
- Partials 445 446 +1
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
arkodg
reviewed
Apr 24, 2023
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature to set defaults in http connection managerWhat this PR does / why we need it:
Sets path normalization settings according to the best practices https://www.envoyproxy.io/docs/envoy/latest/configuration/best_practices/edge
Which issue(s) this PR fixes:
Fixes part of #1048