feat: support envoyproxy & ratelimit deployment container env configu… #1363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1363 +/- ##
=======================================
Coverage 62.19% 62.19%
=======================================
Files 78 77 -1
Lines 10895 10923 +28
=======================================
+ Hits 6776 6794 +18
- Misses 3665 3674 +9
- Partials 454 455 +1
|
qicz
added
kind/enhancement
qicz
requested review from
a team,
kflynn,
zhaohuabing,
chauhanshubham,
zirain,
arkodg,
AliceProxy and
Xunzhuo
and removed request for
a team
qicz
force-pushed
the
support-deployment-env
branch
from
5267dd5
to
db5c684
Compare
…rations. Signed-off-by: qicz <qiczzhu@gmail.com>
qicz
force-pushed
the
support-deployment-env
branch
from
db5c684
to
874f5fe
Compare
arkodg
reviewed
Apr 25, 2023
internal/infrastructure/kubernetes/ratelimit_deployment_test.go
Outdated
Show resolved
Hide resolved
arkodg
reviewed
Apr 25, 2023
internal/infrastructure/kubernetes/ratelimit/resource_provider_test.go
Outdated
Show resolved
Hide resolved
arkodg
reviewed
Apr 25, 2023
qicz
commented
Apr 25, 2023
Signed-off-by: qicz <qiczzhu@gmail.com>
arkodg
reviewed
Apr 26, 2023
arkodg
reviewed
Apr 26, 2023
Signed-off-by: qicz <qiczzhu@gmail.com>
arkodg
approved these changes
Apr 27, 2023
zirain
approved these changes
Apr 27, 2023
This was referenced Apr 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relates: #1294 (comment)