feat: Strip port from host if user specifies a Hostname #1389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1389 +/- ##
==========================================
- Coverage 62.45% 62.38% -0.07%
==========================================
Files 78 78
Lines 10959 10973 +14
==========================================
+ Hits 6844 6846 +2
- Misses 3666 3675 +9
- Partials 449 452 +3
|
arkodg
requested review from
AliceProxy,
a team,
qicz,
LanceEa and
Xunzhuo
and removed request for
a team
arkodg
force-pushed
the
strip-port-from-host
branch
from
534e41b
to
915fbb1
Compare
* This allows us to ignore the port section from the Host header when matching incoming requests based on the Host/Authority header and the Hostname specified by the user Fixes: envoyproxy#1368 Signed-off-by: Arko Dasgupta <arko@tetrate.io>
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
arkodg
force-pushed
the
strip-port-from-host
branch
from
915fbb1
to
afe2d9a
Compare
zirain
approved these changes
May 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
on the Host/Authority header and the Hostname specified by the user
Fixes: #1368