Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: missing NodePort service type description comment #1401

Merged
merged 2 commits into from May 5, 2023

Conversation

chauhanshubham
Copy link
Member

What this PR does / why we need it:
Adds missing comment for NodePort type service

Signed-off-by: Shubham Chauhan <shubham@tetrate.io>
@chauhanshubham chauhanshubham requested a review from a team as a code owner May 5, 2023 07:28
zirain
zirain previously approved these changes May 5, 2023
@chauhanshubham
Copy link
Member Author

chauhanshubham commented May 5, 2023

cc: @zirain wrt #1392 (comment)
the function itself is a service type checker, so I think it's fine to leave it as is?
While checking that out I found that I had missed a comment around the NodePort service type, so added that in this PR.

.
Signed-off-by: Shubham Chauhan <shubham@tetrate.io>
@codecov
Copy link

codecov bot commented May 5, 2023

Codecov Report

Merging #1401 (59da5b8) into main (297fcf1) will decrease coverage by 0.09%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1401      +/-   ##
==========================================
- Coverage   62.44%   62.36%   -0.09%     
==========================================
  Files          79       79              
  Lines       11084    11084              
==========================================
- Hits         6921     6912       -9     
- Misses       3707     3714       +7     
- Partials      456      458       +2     

see 2 files with indirect coverage changes

@zirain
Copy link
Contributor

zirain commented May 5, 2023

cc: @zirain wrt #1392 (comment) the function itself is a service type checker, so I think it's fine to leave it as is? While checking that out I found that I had missed a comment around the NodePort service type, so added that in this PR.

it's ok now, leave it for someone who is new to this project?

@chauhanshubham chauhanshubham requested a review from zirain May 5, 2023 08:08
@qicz
Copy link
Member

qicz commented May 5, 2023

nit: pr title ref https://gateway.envoyproxy.io/latest/dev/CONTRIBUTING.html#submitting-a-pr

@chauhanshubham chauhanshubham changed the title missing NodePort service type description comment docs: missing NodePort service type description comment May 5, 2023
@qicz qicz added area/api API-related issues area/config Issues related to config management, e.g. Config Manager, Config Sources, etc. labels May 5, 2023
@arkodg arkodg merged commit afdea0b into envoyproxy:main May 5, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/api API-related issues area/config Issues related to config management, e.g. Config Manager, Config Sources, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants