Added http best practices to hcm #1408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tanujd11 <dwiveditanuj41@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #1408 +/- ##
==========================================
+ Coverage 62.48% 62.49% +0.01%
==========================================
Files 79 79
Lines 11088 11097 +9
==========================================
+ Hits 6928 6935 +7
- Misses 3704 3706 +2
Partials 456 456
|
arkodg
reviewed
May 8, 2023
arkodg
reviewed
May 8, 2023
arkodg
reviewed
May 8, 2023
Signed-off-by: tanujd11 <dwiveditanuj41@gmail.com>
…y into feat/http-best-practices
15 tasks
zirain
approved these changes
May 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature to set defaults http options in http connection manager
What this PR does / why we need it:
Sets HTTP protocol settings according to the best practices https://www.envoyproxy.io/docs/envoy/latest/configuration/best_practices/edge
Which issue(s) this PR fixes:
Fixes part of #1048