feat: optimize edsClusterConfig for the association between cluster resources and endpoint resources in envoy's configdump?include_eds interface #1414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
sounds good @tmsnan this PR looks fine to me |
qicz
added
kind/enhancement
Signed-off-by: zhaonan <zhaonan06@corp.netease.com>
Signed-off-by: zhaonan <zhaonan06@corp.netease.com>
tmsnan
force-pushed
the
dev-optimize-edsClusterConfig
branch
from
dbcead1
to
a7ec28e
Compare
|
done |
zirain
approved these changes
May 11, 2023
arkodg
approved these changes
May 11, 2023
Codecov Report
@@ Coverage Diff @@
## main #1414 +/- ##
==========================================
+ Coverage 62.26% 62.35% +0.08%
==========================================
Files 79 79
Lines 11184 11185 +1
==========================================
+ Hits 6964 6974 +10
+ Misses 3764 3757 -7
+ Partials 456 454 -2
|
|
@zirain looks like RL E2E is flaky |
tanujd11
pushed a commit
to tanujd11/gateway
that referenced
this pull request
May 20, 2023
…esources and endpoint resources in envoy's configdump?include_eds interface (envoyproxy#1414) * optimize edsClusterConfig Signed-off-by: zhaonan <zhaonan06@corp.netease.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the
config_dump?inclueds_edsinterface of the envoy of the gateway, there is no association information between the endpoints resource and the cluster resource, which is inconvenient for us to troubleshoot, as shown in the following figureAfter optimization, the picture is as follows: