fix: use better log for no gc #1426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: bitliu <bitliu@tencent.com>
Codecov Report
@@ Coverage Diff @@
## main #1426 +/- ##
=======================================
Coverage 62.28% 62.29%
=======================================
Files 79 79
Lines 11260 11260
=======================================
+ Hits 7013 7014 +1
+ Misses 3790 3789 -1
Partials 457 457
|
zirain
approved these changes
May 17, 2023
|
cc @qicz |
qicz
approved these changes
May 17, 2023
zirain
approved these changes
May 17, 2023
tanujd11
pushed a commit
to tanujd11/gateway
that referenced
this pull request
May 20, 2023
Signed-off-by: bitliu <bitliu@tencent.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
fix: use better log for no gc
What this PR does / why we need it:
failedalways means something wrong happened, like an error, but after deploying eg, and I did not create gatewayClass, I see this log which makes me feel weird.