Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rm v2 xds imports #1442

Merged
merged 2 commits into from
May 25, 2023
Merged

rm v2 xds imports #1442

merged 2 commits into from
May 25, 2023

Conversation

arkodg
Copy link
Contributor

@arkodg arkodg commented May 24, 2023

  • not needed since EG doesnt need to maintain compatiblity with xds v2

@arkodg
rm v2 xds imports
a2d5992 
* not needed since EG doesnt need to maintain compatiblity with
xds v2

Signed-off-by: Arko Dasgupta <arko@tetrate.io>
@arkodg arkodg requested a review from a team as a code owner May 24, 2023 02:58
@arkodg arkodg mentioned this pull request May 24, 2023
Merged
@codecov
Copy link

codecov bot commented May 24, 2023 •
edited

Codecov Report

Merging #1442 (1116eaa) into main (5dc86b8) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1442      +/-   ##
==========================================
+ Coverage   61.98%   62.00%   +0.01%     
==========================================
  Files          79       79              
  Lines       11388    11388              
==========================================
+ Hits         7059     7061       +2     
+ Misses       3870     3868       -2     
  Partials      459      459

see 1 file with indirect coverage changes

Xunzhuo
Xunzhuo approved these changes May 25, 2023
View reviewed changes
Copy link
Member

@Xunzhuo Xunzhuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@arkodg arkodg merged commit 554176b into envoyproxy:main May 25, 2023
@arkodg arkodg deleted the rm-xds-v2 branch May 25, 2023 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zirain zirain zirain approved these changes

@Xunzhuo Xunzhuo Xunzhuo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@arkodg @zirain @Xunzhuo