Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove kube provider testdata dir #1448

Merged
merged 1 commit into from May 26, 2023

Conversation

arkodg
Copy link
Contributor

@arkodg arkodg commented May 25, 2023

  • Directly use the GW API CRDs from the helm charts deduping config

* Directly use the GW API CRDs from the helm charts
deduping config

Signed-off-by: Arko Dasgupta <arko@tetrate.io>
@arkodg arkodg requested a review from a team as a code owner May 25, 2023 16:59
@codecov
Copy link

codecov bot commented May 25, 2023

Codecov Report

Merging #1448 (46bd14c) into main (554176b) will increase coverage by 0.08%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1448      +/-   ##
==========================================
+ Coverage   61.92%   62.01%   +0.08%     
==========================================
  Files          79       79              
  Lines       11388    11388              
==========================================
+ Hits         7052     7062      +10     
+ Misses       3875     3867       -8     
+ Partials      461      459       -2     

see 2 files with indirect coverage changes

@arkodg arkodg requested review from a team, kflynn, qicz and LanceEa and removed request for a team May 25, 2023 18:13
Copy link
Member

@qicz qicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zirain zirain merged commit dfb215d into envoyproxy:main May 26, 2023
20 checks passed
@arkodg arkodg deleted the rm-testdata-provider branch May 26, 2023 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants