docs: update accesslog design doc #1449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: hejianpeng <hejianpeng2@huawei.com>
arkodg
previously approved these changes
May 26, 2023
Codecov Report
@@ Coverage Diff @@
## main #1449 +/- ##
==========================================
+ Coverage 61.47% 61.55% +0.07%
==========================================
Files 79 79
Lines 11473 11473
==========================================
+ Hits 7053 7062 +9
+ Misses 3959 3952 -7
+ Partials 461 459 -2 |
zirain
commented
May 26, 2023
| address: otel-collector.monitoring.svc.cluster.local:4317 | ||
| resources: | ||
| k8s.cluster.name: "cluster-1" | ||
| accessLoggings: |
There was a problem hiding this comment.
will move to examples folder and use mdox automate these
qicz
approved these changes
May 26, 2023
qicz
added
documentation
arkodg
approved these changes
May 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
docs: update accesslog design doc
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #