Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Run yamllint on generated Install Manifests #1450

Merged
merged 1 commit into from
May 26, 2023

Conversation

arkodg
Copy link
Contributor

@arkodg arkodg commented May 26, 2023

Fixes: #810

Fixes: envoyproxy#810

Signed-off-by: Arko Dasgupta <arko@tetrate.io>
@arkodg arkodg requested a review from a team as a code owner May 26, 2023 01:41
@codecov
Copy link

codecov bot commented May 26, 2023

Codecov Report

Merging #1450 (3c2315b) into main (554176b) will decrease coverage by 0.47%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1450      +/-   ##
==========================================
- Coverage   61.92%   61.45%   -0.47%     
==========================================
  Files          79       79              
  Lines       11388    11439      +51     
==========================================
- Hits         7052     7030      -22     
- Misses       3875     3948      +73     
  Partials      461      461              

see 8 files with indirect coverage changes

Copy link
Member

@qicz qicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great

@qicz qicz added the area/ci CI and build related issues label May 26, 2023
@qicz qicz added this to the 0.5.0-rc1 milestone May 26, 2023
@arkodg arkodg merged commit 80db459 into envoyproxy:main May 26, 2023
18 checks passed
@arkodg arkodg deleted the enable-yaml-lint branch May 26, 2023 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci CI and build related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Bypassing Gateway API Manifest YAML Linting
3 participants