-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
follow-up: removal of the ratelimit ir #1451
Conversation
Signed-off-by: Shawnh2 <shawnhxh@outlook.com>
Signed-off-by: Shawnh2 <shawnhxh@outlook.com>
Codecov Report
@@ Coverage Diff @@
## main #1451 +/- ##
==========================================
- Coverage 61.48% 61.48% -0.01%
==========================================
Files 79 79
Lines 11439 11410 -29
==========================================
- Hits 7033 7015 -18
+ Misses 3945 3932 -13
- Partials 461 463 +2
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Shawnh2 <shawnhxh@outlook.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the clean up
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
What type of PR is this?
this PR will remove all logic related to ratelimit ir.
What this PR does / why we need it:
we don't need it anymore since the ratelimit have been switched to XDS mode, and the ratelimit can be created by config statically.
Which issue(s) this PR fixes:
related to #1416