Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

follow-up: removal of the ratelimit ir #1451

Merged
merged 5 commits into from
May 30, 2023
Merged

Conversation

shawnh2
Copy link
Contributor

@shawnh2 shawnh2 commented May 26, 2023

What type of PR is this?

this PR will remove all logic related to ratelimit ir.

What this PR does / why we need it:

we don't need it anymore since the ratelimit have been switched to XDS mode, and the ratelimit can be created by config statically.

Which issue(s) this PR fixes:

related to #1416

Signed-off-by: Shawnh2 <shawnhxh@outlook.com>
@shawnh2 shawnh2 requested a review from a team as a code owner May 26, 2023 06:55
internal/cmd/server.go Outdated Show resolved Hide resolved
@qicz qicz added kind/enhancement New feature or request area/infra-mgr Issues related to the provisioner used for provisioning the managed Envoy Proxy fleet. kind/refactor labels May 26, 2023
@qicz qicz added this to the 0.5.0-rc1 milestone May 26, 2023
@codecov
Copy link

codecov bot commented May 27, 2023

Codecov Report

Merging #1451 (b5860f8) into main (1fb3d51) will decrease coverage by 0.01%.
The diff coverage is 45.45%.

@@            Coverage Diff             @@
##             main    #1451      +/-   ##
==========================================
- Coverage   61.48%   61.48%   -0.01%     
==========================================
  Files          79       79              
  Lines       11439    11410      -29     
==========================================
- Hits         7033     7015      -18     
+ Misses       3945     3932      -13     
- Partials      461      463       +2     
Impacted Files Coverage Δ
internal/cmd/server.go 16.66% <0.00%> (+0.91%) ⬆️
internal/ir/zz_generated.deepcopy.go 12.97% <ø> (+0.29%) ⬆️
internal/message/types.go 0.00% <ø> (ø)
...tructure/kubernetes/ratelimit/resource_provider.go 95.83% <100.00%> (-0.05%) ⬇️
...ernal/infrastructure/kubernetes/ratelimit_infra.go 50.00% <100.00%> (-16.67%) ⬇️

... and 2 files with indirect coverage changes

qicz
qicz previously approved these changes May 29, 2023
Copy link
Member

@qicz qicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the clean up

@arkodg arkodg requested review from qicz, a team, kflynn and Xunzhuo and removed request for a team May 30, 2023 18:20
Copy link
Member

@qicz qicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@arkodg arkodg merged commit 903e481 into envoyproxy:main May 30, 2023
19 of 20 checks passed
@shawnh2 shawnh2 deleted the rm-ratelimit-ir branch May 31, 2023 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/infra-mgr Issues related to the provisioner used for provisioning the managed Envoy Proxy fleet. kind/enhancement New feature or request kind/refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants