Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

complement for RL e2e test #1469

Merged
merged 6 commits into from
Jun 2, 2023
Merged

complement for RL e2e test #1469

merged 6 commits into from
Jun 2, 2023

Conversation

shawnh2
Copy link
Contributor

@shawnh2 shawnh2 commented May 31, 2023

What type of PR is this?

remove the two TODO lines in RL e2e test.

What this PR does / why we need it:

  • as for first TODO, wait for deployment/envoy-gateway to finish restart, so the deployment/envoy-ratelimit can be created, and the Sleep can be removed
  • as for second TODO, make the resp and req more explicit

Signed-off-by: Shawnh2 <shawnhxh@outlook.com>
@shawnh2 shawnh2 requested a review from a team as a code owner May 31, 2023 02:25
@codecov
Copy link

codecov bot commented May 31, 2023

Codecov Report

Merging #1469 (ec29db7) into main (22bd06b) will increase coverage by 0.07%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1469      +/-   ##
==========================================
+ Coverage   61.40%   61.48%   +0.07%     
==========================================
  Files          79       79              
  Lines       11459    11459              
==========================================
+ Hits         7036     7045       +9     
+ Misses       3962     3956       -6     
+ Partials      461      458       -3     

see 2 files with indirect coverage changes

Signed-off-by: Shawnh2 <shawnhxh@outlook.com>
Signed-off-by: Shawnh2 <shawnhxh@outlook.com>
Signed-off-by: Shawnh2 <shawnhxh@outlook.com>
@shawnh2
Copy link
Contributor Author

shawnh2 commented May 31, 2023

it's wired that the request to gateway may connect: connection refused few times and then got 200

test/e2e/tests/ratelimit.go Outdated Show resolved Hide resolved
@zirain
Copy link
Contributor

zirain commented Jun 1, 2023

/retest

@zirain zirain merged commit 5ac4655 into envoyproxy:main Jun 2, 2023
18 checks passed
@shawnh2 shawnh2 deleted the rl-e2e branch June 2, 2023 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants