Reduce RL E2E sleep to 3s #1466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
Codecov Report
@@ Coverage Diff @@
## main #1466 +/- ##
=======================================
Coverage 61.43% 61.43%
=======================================
Files 79 79
Lines 11452 11452
=======================================
Hits 7035 7035
Misses 3957 3957
Partials 460 460 |
zirain
approved these changes
May 31, 2023
zirain
reviewed
May 31, 2023
| @@ -35,7 +35,7 @@ var RateLimitTest = suite.ConformanceTest{ | |||
|
|
|||
| // TODO: find a better to make sure ratelimit load new configuration | |||
There was a problem hiding this comment.
we delete/update this lines now?
There was a problem hiding this comment.
we should keep that line until we delete the sleep with something more reliable, like some xds confirmation in route status
There was a problem hiding this comment.
I am working on delete this two TODO lines right now, can refer to #1469
Xunzhuo
approved these changes
May 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.