Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: egctl x translate support for EnvoyPatchPolicy #1682

Merged
merged 4 commits into from
Jul 21, 2023

Conversation

arkodg
Copy link
Contributor

@arkodg arkodg commented Jul 20, 2023

Relates to #24

@arkodg arkodg requested a review from a team as a code owner July 20, 2023 00:18
@arkodg arkodg mentioned this pull request Jul 20, 2023
6 tasks
@codecov
Copy link

codecov bot commented Jul 20, 2023

Codecov Report

Merging #1682 (69822b9) into main (a028ec1) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1682   +/-   ##
=======================================
  Coverage   60.90%   60.91%           
=======================================
  Files          84       84           
  Lines       12575    12589   +14     
=======================================
+ Hits         7659     7668    +9     
- Misses       4424     4428    +4     
- Partials      492      493    +1     
Impacted Files Coverage Δ
internal/cmd/egctl/translate.go 82.87% <100.00%> (+0.35%) ⬆️

... and 2 files with indirect coverage changes

zirain
zirain previously approved these changes Jul 20, 2023
Xunzhuo
Xunzhuo previously approved these changes Jul 20, 2023
@Xunzhuo
Copy link
Member

Xunzhuo commented Jul 20, 2023

CI failed after merging #1681

Relates to envoyproxy#24

Signed-off-by: Arko Dasgupta <arko@tetrate.io>
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
@arkodg arkodg dismissed stale reviews from Xunzhuo and zirain via 69822b9 July 20, 2023 03:28
@arkodg arkodg force-pushed the envoypatchpolicy-translate branch from 8458a4b to 69822b9 Compare July 20, 2023 03:28
@arkodg arkodg requested review from zirain and Xunzhuo July 20, 2023 03:28
@arkodg arkodg requested review from a team, zhaohuabing and qicz and removed request for a team July 21, 2023 15:30
@arkodg arkodg merged commit eeb2df6 into envoyproxy:main Jul 21, 2023
18 checks passed
@arkodg arkodg deleted the envoypatchpolicy-translate branch July 21, 2023 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants