Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ratelimitfilter support for grpcroute #1762

Merged
merged 1 commit into from
Aug 4, 2023

Conversation

shawnh2
Copy link
Contributor

@shawnh2 shawnh2 commented Aug 3, 2023

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #1676

Signed-off-by: sh2 <shawnhxh@outlook.com>
@shawnh2 shawnh2 requested a review from a team as a code owner August 3, 2023 16:01
shawnh2

This comment was marked as duplicate.

@codecov
Copy link

codecov bot commented Aug 3, 2023

Codecov Report

Merging #1762 (8d1fbec) into main (c96aa6a) will increase coverage by 0.10%.
Report is 2 commits behind head on main.
The diff coverage is 58.11%.

@@            Coverage Diff             @@
##             main    #1762      +/-   ##
==========================================
+ Coverage   64.86%   64.97%   +0.10%     
==========================================
  Files          84       84              
  Lines       12018    12181     +163     
==========================================
+ Hits         7796     7915     +119     
- Misses       3732     3760      +28     
- Partials      490      506      +16     
Files Changed Coverage Δ
internal/provider/kubernetes/controller.go 49.35% <0.00%> (-0.19%) ⬇️
internal/xds/translator/jsonpatch.go 30.10% <0.00%> (+0.10%) ⬆️
internal/xds/translator/authentication.go 65.10% <25.00%> (-0.78%) ⬇️
internal/xds/translator/extension.go 72.38% <25.00%> (-1.66%) ⬇️
internal/xds/translator/ratelimit.go 86.26% <25.00%> (-0.88%) ⬇️
internal/xds/translator/translator.go 72.58% <51.02%> (-5.87%) ⬇️
internal/gatewayapi/helpers.go 80.23% <56.52%> (-2.90%) ⬇️
internal/provider/kubernetes/routes.go 44.88% <81.08%> (+9.44%) ⬆️
internal/xds/types/resourceversiontable.go 84.31% <89.09%> (+2.83%) ⬆️
internal/gatewayapi/filters.go 80.12% <100.00%> (+0.06%) ⬆️
... and 2 more

... and 1 file with indirect coverage changes

@@ -0,0 +1,124 @@
gateways:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks !
would be great to add an example in the docs as a follow up PR

Copy link
Contributor

@zirain zirain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, would be good to add an e2e test.

@shawnh2
Copy link
Contributor Author

shawnh2 commented Aug 4, 2023

sure, the doc and e2e test will be added in the follow-up PR

@arkodg arkodg merged commit 57e98a0 into envoyproxy:main Aug 4, 2023
17 of 18 checks passed
@shawnh2 shawnh2 deleted the grpc-rl-filter branch August 4, 2023 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support GRPCRoute + RateLimitFilter
3 participants