-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add ratelimitfilter support for grpcroute #1762
Conversation
Signed-off-by: sh2 <shawnhxh@outlook.com>
Codecov Report
@@ Coverage Diff @@
## main #1762 +/- ##
==========================================
+ Coverage 64.86% 64.97% +0.10%
==========================================
Files 84 84
Lines 12018 12181 +163
==========================================
+ Hits 7796 7915 +119
- Misses 3732 3760 +28
- Partials 490 506 +16
|
internal/gatewayapi/testdata/grpcroute-with-valid-ratelimitfilter.in.yaml
Show resolved
Hide resolved
@@ -0,0 +1,124 @@ | |||
gateways: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be tested out using https://gateway.envoyproxy.io/v0.5.0/user/grpc-routing.html and https://gateway.envoyproxy.io/v0.5.0/user/rate-limit.html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks !
would be great to add an example in the docs as a follow up PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, would be good to add an e2e test.
sure, the |
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #1676