-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
follow-up(doc, fix): support for grpcroute ratelimitfilter #1766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sh2 <shawnhxh@outlook.com>
Signed-off-by: sh2 <shawnhxh@outlook.com>
Codecov Report
@@ Coverage Diff @@
## main #1766 +/- ##
==========================================
- Coverage 64.92% 64.88% -0.05%
==========================================
Files 84 84
Lines 12175 12192 +17
==========================================
+ Hits 7905 7911 +6
- Misses 3763 3774 +11
Partials 507 507
|
Signed-off-by: sh2 <shawnhxh@outlook.com>
arkodg
reviewed
Aug 4, 2023
arkodg
reviewed
Aug 4, 2023
Signed-off-by: sh2 <shawnhxh@outlook.com>
qicz
added
kind/bug
Something isn't working
documentation
Improvements or additions to documentation
kind/refactor
labels
Aug 5, 2023
arkodg
approved these changes
Aug 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks !
Xunzhuo
approved these changes
Aug 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
documentation
Improvements or additions to documentation
kind/bug
Something isn't working
kind/refactor
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
fix: change the logic when dealing with authen and ratelimit filters
refactor: move
getRateLimitFilters
func into filters.go for consistencydoc: add doc for the usage of grpcroute ratelimitfilter
What this PR does / why we need it:
Which issue(s) this PR fixes:
follow-up of #1762