Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

follow-up(doc, fix): support for grpcroute ratelimitfilter #1766

Merged
merged 5 commits into from
Aug 9, 2023

Conversation

shawnh2
Copy link
Contributor

@shawnh2 shawnh2 commented Aug 4, 2023

What type of PR is this?

fix: change the logic when dealing with authen and ratelimit filters

refactor: move getRateLimitFilters func into filters.go for consistency

doc: add doc for the usage of grpcroute ratelimitfilter

What this PR does / why we need it:

Which issue(s) this PR fixes:

follow-up of #1762

Signed-off-by: sh2 <shawnhxh@outlook.com>
Signed-off-by: sh2 <shawnhxh@outlook.com>
@shawnh2 shawnh2 requested a review from a team as a code owner August 4, 2023 09:39
@codecov
Copy link

codecov bot commented Aug 4, 2023

Codecov Report

Merging #1766 (0a8905a) into main (9acbd5d) will decrease coverage by 0.05%.
The diff coverage is 46.15%.

@@            Coverage Diff             @@
##             main    #1766      +/-   ##
==========================================
- Coverage   64.92%   64.88%   -0.05%     
==========================================
  Files          84       84              
  Lines       12175    12192      +17     
==========================================
+ Hits         7905     7911       +6     
- Misses       3763     3774      +11     
  Partials      507      507              
Files Changed Coverage Δ
internal/provider/kubernetes/controller.go 49.14% <ø> (+0.79%) ⬆️
internal/provider/kubernetes/routes.go 43.06% <45.45%> (-1.83%) ⬇️
internal/provider/kubernetes/filters.go 56.52% <50.00%> (-2.31%) ⬇️

... and 1 file with indirect coverage changes

Signed-off-by: sh2 <shawnhxh@outlook.com>
Signed-off-by: sh2 <shawnhxh@outlook.com>
@qicz qicz added kind/bug Something isn't working documentation Improvements or additions to documentation kind/refactor labels Aug 5, 2023
@qicz qicz added this to the 0.6.0-rc1 milestone Aug 5, 2023
Copy link
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks !

@Xunzhuo Xunzhuo merged commit 8019ae4 into envoyproxy:main Aug 9, 2023
17 of 18 checks passed
@shawnh2 shawnh2 deleted the doc-grpc-rlfilter branch August 9, 2023 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation kind/bug Something isn't working kind/refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants