Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix a typo: disabled -> disable #1843

Merged
merged 1 commit into from
Aug 29, 2023
Merged

Conversation

rootsongjc
Copy link
Member

@rootsongjc rootsongjc commented Aug 29, 2023

What type of PR is this?

  • docs: fix a typo: disabled -> disable, the API actually is telemetry.accesslog.disable not telemetry.accesslog.disabled. I fixed the typo in the docs and example YAML files. See the API types.

@rootsongjc rootsongjc requested a review from a team as a code owner August 29, 2023 13:02
Signed-off-by: Jimmy Song <rootsongjc@gmail.com>
@codecov
Copy link

codecov bot commented Aug 29, 2023

Codecov Report

Merging #1843 (47f51af) into main (de2befb) will decrease coverage by 0.11%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1843      +/-   ##
==========================================
- Coverage   65.22%   65.12%   -0.11%     
==========================================
  Files          86       86              
  Lines       12476    12476              
==========================================
- Hits         8138     8125      -13     
- Misses       3821     3831      +10     
- Partials      517      520       +3     

see 2 files with indirect coverage changes

Copy link
Contributor

@zirain zirain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@Xunzhuo Xunzhuo merged commit d53dc1f into envoyproxy:main Aug 29, 2023
18 checks passed
@rootsongjc rootsongjc deleted the accesslog branch August 30, 2023 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants