Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix a typo: disabled -> disable #1843

Merged
merged 1 commit into from
Aug 29, 2023
Merged

fix a typo: disabled -> disable #1843

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/latest/design/accesslog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ metadata:
spec:
telemetry:
accessLog:
disabled: true
disable: true
```

2. The following is an example with text format access log.
Expand Down
4 changes: 2 additions & 2 deletions docs/latest/user/proxy-observability.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ Verify logs from loki:
curl -s "http://$LOKI_IP:3100/loki/api/v1/query_range" --data-urlencode "query={job=\"fluentbit\"}" | jq '.data.result[0].values'
```

If you want to disable it, set the `telemetry.accesslog.disabled` to `true` in the `EnvoyProxy` CRD.
If you want to disable it, set the `telemetry.accesslog.disable` to `true` in the `EnvoyProxy` CRD.

```shell
kubectl apply -f https://raw.githubusercontent.com/envoyproxy/gateway/latest/examples/kubernetes/accesslog/disable-accesslog.yaml
Expand Down Expand Up @@ -130,4 +130,4 @@ curl -s "http://$TEMPO_IP:3100/api/search" --data-urlencode "q={ component=envoy

```shell
curl -s "http://$TEMPO_IP:3100/api/traces/<trace_id>" | jq
```
```
2 changes: 1 addition & 1 deletion docs/v0.5.0/design/accesslog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ metadata:
spec:
telemetry:
accessLog:
disabled: true
disable: true
```

2. The following is an example with text format access log.
Expand Down
4 changes: 2 additions & 2 deletions docs/v0.5.0/user/proxy-observability.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ Verify logs from loki:
curl -s "http://$LOKI_IP:3100/loki/api/v1/query_range" --data-urlencode "query={job=\"fluentbit\"}" | jq '.data.result[0].values'
```

If you want to disable it, set the `telemetry.accesslog.disabled` to `true` in the `EnvoyProxy` CRD.
If you want to disable it, set the `telemetry.accesslog.disable` to `true` in the `EnvoyProxy` CRD.

```shell
kubectl apply -f https://raw.githubusercontent.com/envoyproxy/gateway/latest/examples/kubernetes/accesslog/disable-accesslog.yaml
Expand Down Expand Up @@ -130,4 +130,4 @@ curl -s "http://$TEMPO_IP:3100/api/search" --data-urlencode "q={ component=envoy

```shell
curl -s "http://$TEMPO_IP:3100/api/traces/<trace_id>" | jq
```
```
2 changes: 1 addition & 1 deletion examples/kubernetes/accesslog/disable-accesslog.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,4 +18,4 @@ metadata:
spec:
telemetry:
accessLog:
disabled: true
disable: true