Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add unmarshal error to EnvoyPatchPolicy status #1859

Merged
merged 2 commits into from
Sep 1, 2023

Conversation

zhaohuabing
Copy link
Member

@zhaohuabing zhaohuabing commented Sep 1, 2023

What type of PR is this?

This PR add unmarshal error to EnvoyPatchPolicy status to make our lives a bit easier :-)

Before:

  - lastTransitionTime: "2023-09-01T02:48:06Z"
    message: unable to unmarshal xds resource {"name":"teg-e2e-test/teg/https","virtual_hosts":[{"name":"teg-e2e-test/teg/https/www_example_com","domains":["www.example.com"],"routes":[{"name":"httproute/teg-e2e-test/http-oidc-authn-policy/rule/0/match/0/www_example_com","match":{"prefix":"/"},"route":{"cluster":"httproute/teg-e2e-test/http-oidc-authn-policy/rule/0"}}],"typed_per_filter_config":{"envoy.filters.http.dynamic_forward_proxy":{"allow_headers":"keep-alive,user-agent,cache-control,content-type,content-transfer-encoding,custom-header-1,x-accept-content-transfer-encoding,x-accept-response-streaming,x-user-agent,x-grpc-web,grpc-timeout","allow_methods":"GET,
      PUT, DELETE, POST, OPTIONS","allow_origin_string_match":[{"prefix":"*"}],"expose_headers":"custom-header-1,grpc-status,grpc-message"}}}],"ignore_port_in_host_matching":true}
    reason: Invalid
    status: "False"
    type: Programmed

After:

  - lastTransitionTime: "2023-09-01T02:56:50Z"
    message: 'unable to unmarshal xds resource {"name":"teg-e2e-test/teg/https","virtual_hosts":[{"name":"teg-e2e-test/teg/https/www_example_com","domains":["www.example.com"],"routes":[{"name":"httproute/teg-e2e-test/http-oidc-authn-policy/rule/0/match/0/www_example_com","match":{"prefix":"/"},"route":{"cluster":"httproute/teg-e2e-test/http-oidc-authn-policy/rule/0"}}],"typed_per_filter_config":{"envoy.filters.http.dynamic_forward_proxy":{"allow_headers":"keep-alive,user-agent,cache-control,content-type,content-transfer-encoding,custom-header-1,x-accept-content-transfer-encoding,x-accept-response-streaming,x-user-agent,x-grpc-web,grpc-timeout","allow_methods":"GET,
      PUT, DELETE, POST, OPTIONS","allow_origin_string_match":[{"prefix":"*"}],"expose_headers":"custom-header-1,grpc-status,grpc-message"}}}],"ignore_port_in_host_matching":true},
      err:proto: (line 1:397): missing "@type" field'
    reason: Invalid
    status: "False"
    type: Programmed

Signed-off-by: huabing zhao <zhaohuabing@gmail.com>
@zhaohuabing zhaohuabing requested a review from a team as a code owner September 1, 2023 03:00
zirain
zirain previously approved these changes Sep 1, 2023
@Xunzhuo
Copy link
Member

Xunzhuo commented Sep 1, 2023

Plz resolve the CI errors first : )

Signed-off-by: huabing zhao <zhaohuabing@gmail.com>
@codecov
Copy link

codecov bot commented Sep 1, 2023

Codecov Report

Merging #1859 (e6e0496) into main (a324513) will decrease coverage by 0.02%.
The diff coverage is 12.50%.

@@            Coverage Diff             @@
##             main    #1859      +/-   ##
==========================================
- Coverage   65.24%   65.22%   -0.02%     
==========================================
  Files          86       86              
  Lines       12480    12480              
==========================================
- Hits         8142     8140       -2     
- Misses       3821     3823       +2     
  Partials      517      517              
Files Changed Coverage Δ
internal/xds/translator/jsonpatch.go 30.10% <12.50%> (ø)

... and 3 files with indirect coverage changes

@zhaohuabing
Copy link
Member Author

@zirain @Xunzhuo is codecov/patch a must for a PR to get merged?

@zirain
Copy link
Contributor

zirain commented Sep 1, 2023

@zirain @Xunzhuo is codecov/patch a must for a PR to get merged?

it's not a must

@Xunzhuo Xunzhuo merged commit 3e0ba18 into envoyproxy:main Sep 1, 2023
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants