Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: refactor string match #2102

Merged
merged 6 commits into from
Nov 6, 2023
Merged

chore: refactor string match #2102

merged 6 commits into from
Nov 6, 2023

Conversation

zhaohuabing
Copy link
Member

@zhaohuabing zhaohuabing commented Oct 28, 2023 •
edited
Loading

fix: #2067

  • use the shared string match for stats match condition
  • rename string match type in shared types, if no special requirement like 'Distinct' in Rate limit, all the other EG APIs should consider using this common string match type
  • use the shared string match for rate limit - removed after discussion

@zhaohuabing
refactor: string match
476ec69 
Signed-off-by: huabing zhao <zhaohuabing@gmail.com>
@zhaohuabing zhaohuabing requested a review from a team as a code owner October 28, 2023 02:38
@zhaohuabing zhaohuabing marked this pull request as draft October 28, 2023 02:39
@codecov
Copy link

codecov bot commented Oct 28, 2023 •
edited
Loading

Codecov Report

Merging #2102 (7632713) into main (d65ab59) will decrease coverage by 0.09%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2102      +/-   ##
==========================================
- Coverage   64.32%   64.23%   -0.09%     
==========================================
  Files         107      107              
  Lines       14623    14630       +7     
==========================================
- Hits         9406     9398       -8     
- Misses       4654     4666      +12     
- Partials      563      566       +3
Files Coverage Δ
internal/gatewayapi/securitypolicy.go 78.60% <100.00%> (ø)
internal/xds/bootstrap/bootstrap.go 86.84% <100.00%> (+1.33%) ⬆️

... and 1 file with indirect coverage changes

@zhaohuabing
use shared string match for rate limit
ee81ddf 
Signed-off-by: huabing zhao <zhaohuabing@gmail.com>
@zhaohuabing zhaohuabing marked this pull request as ready for review October 29, 2023 13:57
@zhaohuabing
revert Rate Limit HeaderMatch
aca052d 
Signed-off-by: huabing zhao <zhaohuabing@gmail.com>
@zhaohuabing
Merge branch 'main' into string-match
1372494 
Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>
@zhaohuabing
use common string match for stats match
e79793a 
Signed-off-by: huabing zhao <zhaohuabing@gmail.com>
@zhaohuabing
fix generate
7632713 
Signed-off-by: huabing zhao <zhaohuabing@gmail.com>
arkodg
arkodg approved these changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks !

@arkodg
Copy link
Contributor

arkodg commented Oct 30, 2023

should we merge this post v0.6 ?

@zhaohuabing
Copy link
Member Author

should we merge this post v0.6 ?

I'm OK with that.

@zirain zirain added this to the Backlog milestone Oct 30, 2023
@zhaohuabing
Copy link
Member Author

@arkodg can we merge it now? v0.6 has been released.

@arkodg arkodg merged commit 46bb51a into envoyproxy:main Nov 6, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zirain zirain zirain approved these changes

@arkodg arkodg arkodg approved these changes

@Xunzhuo Xunzhuo Awaiting requested review from Xunzhuo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.

chore: refactory string matcher
3 participants
@zhaohuabing @arkodg @zirain