Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default ctrl plane cert expiry time to 5 years #2175

Merged
merged 5 commits into from
Nov 14, 2023

Conversation

arkodg
Copy link
Contributor

@arkodg arkodg commented Nov 10, 2023

…y#2047)"

This reverts commit 6b2c0e6.

Signed-off-by: Arko Dasgupta <arko@tetrate.io>
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
@arkodg arkodg requested a review from a team as a code owner November 10, 2023 22:43
@arkodg arkodg requested a review from qicz November 10, 2023 22:43
Copy link

codecov bot commented Nov 10, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (397911d) 64.24% compared to head (97115f3) 64.22%.

Files Patch % Lines
internal/cmd/certgen.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2175      +/-   ##
==========================================
- Coverage   64.24%   64.22%   -0.03%     
==========================================
  Files         107      107              
  Lines       14922    14922              
==========================================
- Hits         9586     9583       -3     
- Misses       4762     4764       +2     
- Partials      574      575       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Arko Dasgupta <arko@tetrate.io>
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
@arkodg arkodg requested review from a team, LanceEa and Xunzhuo and removed request for a team November 13, 2023 17:31
@zirain zirain enabled auto-merge (squash) November 14, 2023 01:38
@zirain zirain merged commit f92da90 into envoyproxy:main Nov 14, 2023
17 of 18 checks passed
@arkodg arkodg deleted the default-ctrl-plane-cert-expiry branch November 14, 2023 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants