-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix weighted route #2187
Fix weighted route #2187
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks for solving this one !
|
@arkodg how about changing the locality name to |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2187 +/- ##
==========================================
+ Coverage 64.17% 64.22% +0.05%
==========================================
Files 107 107
Lines 14922 14924 +2
==========================================
+ Hits 9576 9585 +9
+ Misses 4770 4764 -6
+ Partials 576 575 -1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: huabing zhao <zhaohuabing@gmail.com>
Signed-off-by: huabing zhao <zhaohuabing@gmail.com>
This reverts commit e051644. Signed-off-by: huabing zhao <zhaohuabing@gmail.com>
a3d3bc5
to
7fa2aa0
Compare
fix #2170
Envoy requires a distinct region to be set for each LocalityLbEndpoints. If we don't do this, Envoy will merge all LocalityLbEndpoints into one. In this PR, the name of the backendRef is used as a pseudo region name to avoid this issue.
HTTPRoute
EDS