Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: proxyProtocol in BackendTrafficPolicy #2192

Merged
merged 2 commits into from
Nov 23, 2023

Conversation

arkodg
Copy link
Contributor

@arkodg arkodg commented Nov 15, 2023

relates to #1328

@arkodg arkodg requested a review from a team as a code owner November 15, 2023 20:47
@arkodg arkodg marked this pull request as draft November 15, 2023 20:47
Copy link

codecov bot commented Nov 15, 2023

Codecov Report

Attention: 30 lines in your changes are missing coverage. Please review.

Comparison is base (87bc96f) 64.49% compared to head (12e3e10) 64.50%.

Files Patch % Lines
internal/xds/translator/cluster.go 64.44% 13 Missing and 3 partials ⚠️
internal/ir/zz_generated.deepcopy.go 0.00% 13 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2192   +/-   ##
=======================================
  Coverage   64.49%   64.50%           
=======================================
  Files         111      111           
  Lines       15399    15482   +83     
=======================================
+ Hits         9932     9986   +54     
- Misses       4855     4880   +25     
- Partials      612      616    +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@arkodg arkodg marked this pull request as ready for review November 15, 2023 23:26
@arkodg arkodg requested review from a team, qicz, AliceProxy and cnvergence and removed request for a team November 15, 2023 23:26
@arkodg
Copy link
Contributor Author

arkodg commented Nov 15, 2023

cc @JuniorJPDJ

Copy link
Member

@zhaohuabing zhaohuabing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@arkodg arkodg enabled auto-merge (squash) November 16, 2023 22:28
@arkodg arkodg requested a review from zirain November 17, 2023 16:47
@arkodg arkodg force-pushed the implement-proxy-protocol-btp branch from 7e509c3 to fcf9ad0 Compare November 22, 2023 17:12
zirain
zirain previously approved these changes Nov 22, 2023
relates to envoyproxy#1328

Signed-off-by: Arko Dasgupta <arko@tetrate.io>
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
@arkodg arkodg merged commit 571f8bf into envoyproxy:main Nov 23, 2023
18 checks passed
@arkodg arkodg deleted the implement-proxy-protocol-btp branch November 23, 2023 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants