Make DiscoveryServer stream ID global

envoyproxy · Dec 16, 2020 · 2dddc8f · 2dddc8f
1 parent ff834cb
commit 2dddc8f
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 3 deletions.
diff --git a/server/src/main/java/io/envoyproxy/controlplane/server/DiscoveryServer.java b/server/src/main/java/io/envoyproxy/controlplane/server/DiscoveryServer.java
@@ -10,7 +10,6 @@
 import java.util.Collection;
 import java.util.List;
 import java.util.concurrent.Executor;
-import java.util.concurrent.atomic.AtomicLong;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
@@ -21,7 +20,6 @@ public abstract class DiscoveryServer<T, U> {
   final ConfigWatcher configWatcher;
   final ProtoResourcesSerializer protoResourcesSerializer;
   private final ExecutorGroup executorGroup;
-  private final AtomicLong streamCount = new AtomicLong();
 
   /**
    * Creates the server.
@@ -59,7 +57,7 @@ StreamObserver<T> createRequestHandler(
       boolean ads,
       String defaultTypeUrl) {
 
-    long streamId = streamCount.getAndIncrement();
+    long streamId = StreamCounter.getAndIncrement();
     Executor executor = executorGroup.next();
 
     LOGGER.debug("[{}] open stream from {}", streamId, defaultTypeUrl);

diff --git a/server/src/main/java/io/envoyproxy/controlplane/server/StreamCounter.java b/server/src/main/java/io/envoyproxy/controlplane/server/StreamCounter.java
@@ -0,0 +1,11 @@
+package io.envoyproxy.controlplane.server;
+
+import java.util.concurrent.atomic.AtomicLong;
+
+public final class StreamCounter {
+  private static final AtomicLong streamCount = new AtomicLong();
+
+  public static long getAndIncrement() {
+    return streamCount.getAndIncrement();
+  }
+}