Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make DiscoveryServer stream ID global #157

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Make DiscoveryServer stream ID global #157

wants to merge 1 commit into from

Commits on Dec 16, 2020

  1. Make DiscoveryServer stream ID global 

    When surfacing V2 and V3 streams alongside each other in envoy-control,
DiscoveryServerCallbacks are unable to differentiate between V2 & V3 ADS
upon onStreamClose(), onStreamCloseWithError().

This means that any DiscoveryServerCallback that keeps state cannot pivot
on stream IDs, since there will be duplicate between V2 & V3. This change
creates a global StreamCounter, which ensures stream IDs will be unique
across V2 & V3 streams.

Signed-off-by: Stephanie Tilden <stephanietilden@squareup.com>
    Stephanie Tilden committed Dec 16, 2020
    Configuration menu
    Copy the full SHA
    91da9e9 View commit details
    Browse the repository at this point in the history