Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump protobuf-maven-plugin version and fix Windows build #82

Merged
merged 1 commit into from Nov 13, 2018

Conversation

aramperes
Copy link
Contributor

See xolstice/protobuf-maven-plugin#5

  • Bump protobuf-maven-plugin to 0.6.1
  • Use the useArgumentFile as it fixes builds on Windows (due to the Windows command line limit)

Signed-off-by: momothereal <momothereal.mc@gmail.com>
@codecov-io
Copy link

codecov-io commented Nov 13, 2018

Codecov Report

Merging #82 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #82   +/-   ##
=========================================
  Coverage     94.62%   94.62%           
  Complexity      130      130           
=========================================
  Files            13       13           
  Lines           502      502           
  Branches         44       44           
=========================================
  Hits            475      475           
  Misses           18       18           
  Partials          9        9

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be372d6...de15b83. Read the comment docs.

Copy link
Contributor

@snowp snowp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@snowp snowp merged commit e1666f2 into envoyproxy:master Nov 13, 2018
@aramperes aramperes deleted the fix-windows-build branch November 13, 2018 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants