Fixes ENYO-3204 adds guard for setting the value of a select box in <= IE11 #1415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanjduffy
force-pushed
the
ENYO-3204-ryanjduffy
branch
3 times, most recently
from
9f8d283
to
2687057
Compare
| this.updateSelectedFromNode(); | ||
| // IE will clear selectedIndex when setting the value directly on the node so instead we | ||
| // iterate the children, find the matching value, and update selected if necessary. | ||
| if (platform.ie) { |
There was a problem hiding this comment.
we should check platform.ie || platform.edge
ryanjduffy
force-pushed
the
ENYO-3204-ryanjduffy
branch
from
2687057
to
b3dd93d
Compare
Issue: ENYO-3204 Enyo-DCO-1.1-Signed-off-by: Ryan Duffy (ryan.duffy@lge.com)
ryanjduffy
force-pushed
the
ENYO-3204-ryanjduffy
branch
from
b3dd93d
to
3388090
Compare
aarontam
added a commit
that referenced
this pull request
Mar 15, 2016
Fixes ENYO-3204 adds guard for setting the value of a select box in <= IE11 Reviewed-by: Stephen Choi (stephen.choi@lge.com) Integrated-By: Aaron Tam (aaron.tam@lge.com)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enyo-DCO-1.1-Signed-off-by: Ryan Duffy (ryan.duffy@lge.com)