ENYO-3219: Refresh scroll thresholds when adding / removing models #1422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a list is scrolled to the end and the size of the collection changes, we need to recalculate the scroll thresholds and possibly adjust the range of items to be rendered. Until now, we've only adjusted thresholds in the `scroll()` method, based on the direction and distance we've scrolled. In this fix, we add a new method, `refreshThresholds()`, which recalculates the thresholds based on the current scroll value. We call the new method from `modelsAdded()` and `modelsRemoved()` to make sure that the thresholds and item range are correct after the size of the collection has changed. Enyo-DCO-1.1-Signed-Off-By: Gray Norton (gray.norton@lge.com)
ryanjduffy
added a commit
that referenced
this pull request
Mar 21, 2016
ENYO-3219: Refresh scroll thresholds when adding / removing models Integrated-By: Ryan Duffy (ryan.duffy@lge.com)
| v = (this.direction === 'vertical'), | ||
| val = v ? this.scrollTop : this.scrollLeft, | ||
| delta = this.delta, | ||
| cb = this.cachedBounds ? this.cachedBounds : this._getScrollBounds(), |
There was a problem hiding this comment.
Does 'scroll threshold' also updated on showing change if we update collection while data list is hidden?
There was a problem hiding this comment.
@KunmyonChoi, at a glance, I don't think so. I think it would be relatively straightforward to make it happen, though -- we would just override showingChangedHandler() and call refreshThresholds() before calling the super method. If you write up a JIRA demonstrating a problem case, we will take a look.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a list is scrolled to the end and the size of the collection
changes, we need to recalculate the scroll thresholds and possibly
adjust the range of items to be rendered.
Until now, we've only adjusted thresholds in the
scroll()method,based on the direction and distance we've scrolled. In this fix, we
add a new method,
refreshThresholds(), which recalculates thethresholds based on the current scroll value. We call the new
method from
modelsAdded()andmodelsRemoved()to make sure thatthe thresholds and item range are correct after the size of the
collection has changed.
Enyo-DCO-1.1-Signed-Off-By: Gray Norton (gray.norton@lge.com)