ENYO-3219: Refresh scroll thresholds when adding / removing models #1422
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a list is scrolled to the end and the size of the collection
changes, we need to recalculate the scroll thresholds and possibly
adjust the range of items to be rendered.
Until now, we've only adjusted thresholds in the
scroll()
method,based on the direction and distance we've scrolled. In this fix, we
add a new method,
refreshThresholds()
, which recalculates thethresholds based on the current scroll value. We call the new
method from
modelsAdded()
andmodelsRemoved()
to make sure thatthe thresholds and item range are correct after the size of the
collection has changed.
Enyo-DCO-1.1-Signed-Off-By: Gray Norton (gray.norton@lge.com)