Timo/fix quadr complexity #11
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crusso
reviewed
Nov 17, 2021
| Nat32.fromIntWrap(Nat8.toNat(p[j + 1])) << 16 | | ||
| Nat32.fromIntWrap(Nat8.toNat(p[j + 2])) << 08 | | ||
| Nat32.fromIntWrap(Nat8.toNat(p[j + 3])) << 00; | ||
| Nat32.fromIntWrap(Nat8.toNat(data[start + j + 0])) << 24 | |
There was a problem hiding this comment.
Can't these just be Nat32.fromNat or do you want to avoid the redundant overflow check?
There was a problem hiding this comment.
You mean Nat32.fromNat(Nat8.toNat(..))?
There was a problem hiding this comment.
Yup. But perhaps the existing is faster since it doesn't check for overflow
There was a problem hiding this comment.
I tested it. fromIntWrap is slightly cheaper than fromNat.
crusso
reviewed
Nov 17, 2021
| while (p.size() >= 64) { | ||
| var start = 0; | ||
| var len = data.size(); | ||
| while (len >= 64) { | ||
| var j = 0; | ||
| for (i in Iter.range(0, 15)) { |
There was a problem hiding this comment.
The for loop might be quicker as a while loop starting j from start, incrementing by 4 up to a pre-computed bound.
There was a problem hiding this comment.
But i has to increment, too.
Why exactly would it be quicker?
skilesare
added a commit
to skilesare/crypto.mo
that referenced
this pull request
Jan 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copying the whole data with every chunk caused quadratic complexity.