fix contain and containMatchingElement and to accept string values #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this pr address #204 |
ljharb
approved these changes
Oct 11, 2017
src/reactNodeToString.js
Outdated
| @@ -20,6 +20,8 @@ function reactArrayToJSXString (nodes) { | |||
| export default function reactNodeToString (node) { | |||
| if (Array.isArray(node)) { | |||
| return reactArrayToJSXString(node) | |||
| } else if (typeof node !== 'object') { | |||
There was a problem hiding this comment.
I'm not so sure about this check; should it maybe just be "if it's a string, return it"?
There was a problem hiding this comment.
I think I agree. @lelandrichardson suggested this way, but I think that having it throw when supplied say a number is better and more accurate then coercing it into a string.
There was a problem hiding this comment.
Is there a use case for allowing a non-string to work? It seems like that's likely to be a bug more than .to.contain(3) is used for convenience.
before, a string was accepted via react-element-to-jsx-string. As that is no longer being used in favor of a custom function, a string should still be accepted.
|
Looks like this breaks when using enzyme 2 (see travis) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
before, a string was accepted via react-element-to-jsx-string.
As that is no longer being used in favor of a custom function,
a string should still be accepted.