Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] shallow/mount: renderProp: avoid warning when renderProp function returns null #2076

Merged
merged 1 commit into from
Mar 31, 2019

Conversation

bscharm
Copy link
Contributor

@bscharm bscharm commented Mar 30, 2019

Fixes #2059

Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Expanded your tests to ensure it throws with undefined, and used explicitNull from airbnb-prop-types.

@ljharb ljharb force-pushed the master branch 2 times, most recently from 18a4fab to 6ad2165 Compare March 31, 2019 21:06
@ljharb ljharb merged commit 6ad2165 into enzymejs:master Mar 31, 2019
ljharb added a commit that referenced this pull request Apr 6, 2019
 - [new] `Utils` add `findElement`, `getNodeFromRootFinder`, `wrapWithWrappingComponent`, `getWrappingComponentMountRenderer`; add `RootFinder` (#1966)
 - [new] add `getDerivedStateFromError` support (#2036)
 - [fix] `shallow`/`mount`: `renderProp`: avoid warning when render prop returns `null` (#2076)
 - [build] include source maps
 - [deps] update `eslint`
 - [dev deps] update `eslint`, `semver`, `rimraf`, `react-is`, `html-element-map`, `chai`, `eslint-plugin-mocha`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants