Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update junit5 monorepo to v5.10.2 #101

Merged
merged 1 commit into from
Feb 7, 2024
Merged

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Feb 4, 2024

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
org.junit.jupiter:junit-jupiter-params (source) 5.10.1 -> 5.10.2 age adoption passing confidence
org.junit.jupiter:junit-jupiter-api (source) 5.10.1 -> 5.10.2 age adoption passing confidence

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@zoeself
Copy link
Collaborator

zoeself commented Feb 4, 2024

@renovate[bot] thank you for your Pull Request. I'll assign someone to review it soon.

If this PR solves a todo from the code, please don't forget to remove it.

Copy link

codecov bot commented Feb 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (217ea2d) 64.16% compared to head (8c02232) 64.16%.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #101   +/-   ##
=========================================
  Coverage     64.16%   64.16%           
  Complexity       27       27           
=========================================
  Files            13       13           
  Lines           120      120           
=========================================
  Hits             77       77           
  Misses           43       43           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zoeself
Copy link
Collaborator

zoeself commented Feb 4, 2024

@l3r8yJ please review this Pull Request. Deadline (when it should be merged or closed) is 2024-02-07T10:59:11.288575.

You should check if the requirements have been implemented (partially or in full), if there are unit tests covering the changes and if the CI build passes. Feel free to reject the PR or ask for changes if it's too big or not clear enough.

Estimation here is 30 minutes, that's how much you will be paid. You will be paid even if this PR gets rejected.

@zoeself
Copy link
Collaborator

zoeself commented Feb 6, 2024

@l3r8yJ Don't forget to close this ticket before the deadline (2024-02-07T10:59:11). You are past the first half of the allowed period.

@zoeself zoeself removed the @l3r8yJ label Feb 7, 2024
@zoeself
Copy link
Collaborator

zoeself commented Feb 7, 2024

@l3r8yJ Looks like you've missed the task deadline (2024-02-07T10:59:11). You are now resigned from this task.

Please stop working on it, you will not be paid. I will assign it to someone else soon.

@zoeself
Copy link
Collaborator

zoeself commented Feb 7, 2024

@h1alexbel please review this Pull Request. Deadline (when it should be merged or closed) is 2024-02-10T11:29:18.521468.

You should check if the requirements have been implemented (partially or in full), if there are unit tests covering the changes and if the CI build passes. Feel free to reject the PR or ask for changes if it's too big or not clear enough.

Estimation here is 30 minutes, that's how much you will be paid. You will be paid even if this PR gets rejected.

@h1alexbel
Copy link
Member

@rultor merge

@rultor
Copy link
Collaborator

rultor commented Feb 7, 2024

@rultor merge

@h1alexbel OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit 8c02232 into master Feb 7, 2024
12 checks passed
@rultor
Copy link
Collaborator

rultor commented Feb 7, 2024

@rultor merge

@h1alexbel Done! FYI, the full log is here (took me 2min)

@renovate renovate bot deleted the renovate/junit5-monorepo branch February 7, 2024 19:47
@zoeself
Copy link
Collaborator

zoeself commented Feb 7, 2024

@h1alexbel thank you for resolving this ticket. I've just added it to your active invoice. You can always check all your invoices and more on the Contributor Dashboard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants