Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update slf4j monorepo to v2.0.13 #116

Merged
merged 1 commit into from
Apr 16, 2024
Merged

Update slf4j monorepo to v2.0.13 #116

merged 1 commit into from
Apr 16, 2024

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Apr 12, 2024

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
org.slf4j:slf4j-simple (source, changelog) 2.0.12 -> 2.0.13 age adoption passing confidence
org.slf4j:slf4j-api (source, changelog) 2.0.12 -> 2.0.13 age adoption passing confidence

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@zoeself
Copy link
Collaborator

zoeself commented Apr 12, 2024

@renovate[bot] thank you for your Pull Request. I'll assign someone to review it soon.

If this PR solves a todo from the code, please don't forget to remove it.

Copy link

codecov bot commented Apr 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.16%. Comparing base (7d8efb7) to head (912f233).

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #116   +/-   ##
=========================================
  Coverage     64.16%   64.16%           
  Complexity       27       27           
=========================================
  Files            13       13           
  Lines           120      120           
=========================================
  Hits             77       77           
  Misses           43       43           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zoeself
Copy link
Collaborator

zoeself commented Apr 12, 2024

@l3r8yJ please review this Pull Request. Deadline (when it should be merged or closed) is 2024-04-15T17:49:09.870033.

You should check if the requirements have been implemented (partially or in full), if there are unit tests covering the changes and if the CI build passes. Feel free to reject the PR or ask for changes if it's too big or not clear enough.

Estimation here is 30 minutes, that's how much you will be paid. You will be paid even if this PR gets rejected.

@zoeself
Copy link
Collaborator

zoeself commented Apr 14, 2024

@l3r8yJ Don't forget to close this ticket before the deadline (2024-04-15T17:49:10). You are past the first half of the allowed period.

@zoeself
Copy link
Collaborator

zoeself commented Apr 15, 2024

@l3r8yJ Looks like you've missed the task deadline (2024-04-15T17:49:10). You are now resigned from this task.

Please stop working on it, you will not be paid. I will assign it to someone else soon.

@zoeself
Copy link
Collaborator

zoeself commented Apr 15, 2024

@h1alexbel please review this Pull Request. Deadline (when it should be merged or closed) is 2024-04-18T17:59:13.609890.

You should check if the requirements have been implemented (partially or in full), if there are unit tests covering the changes and if the CI build passes. Feel free to reject the PR or ask for changes if it's too big or not clear enough.

Estimation here is 30 minutes, that's how much you will be paid. You will be paid even if this PR gets rejected.

@h1alexbel
Copy link
Member

@rultor merge

@rultor
Copy link
Collaborator

rultor commented Apr 16, 2024

@rultor merge

@h1alexbel OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit 912f233 into master Apr 16, 2024
12 checks passed
@rultor
Copy link
Collaborator

rultor commented Apr 16, 2024

@rultor merge

@h1alexbel Done! FYI, the full log is here (took me 2min)

@renovate renovate bot deleted the renovate/slf4j-monorepo branch April 16, 2024 06:19
@zoeself
Copy link
Collaborator

zoeself commented Apr 16, 2024

@h1alexbel thank you for resolving this ticket. I've just added it to your active invoice. You can always check all your invoices and more on the Contributor Dashboard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants