-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fail on error true #46
Conversation
@h1alexbel thank you for your Pull Request. I'll assign someone to review it soon. If this PR solves a |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #46 +/- ##
=========================================
Coverage 94.96% 94.96%
Complexity 84 84
=========================================
Files 11 11
Lines 159 159
Branches 3 3
=========================================
Hits 151 151
Misses 8 8 ☔ View full report in Codecov by Sentry. |
@h1alexbel please review this Pull Request. Deadline (when it should be merged or closed) is You should check if the requirements have been implemented (partially or in full), if there are unit tests covering the changes and if the CI build passes. Feel free to reject the PR or ask for changes if it's too big or not clear enough. Estimation here is |
@rultor merge |
@h1alexbel OK, I'll try to merge now. You can check the progress of the merge here |
@h1alexbel Done! FYI, the full log is here (took me 2min) |
@h1alexbel thank you for resolving this ticket. I've just added it to your active invoice. You can always check all your invoices and more on the Contributor Dashboard. |
closes #10
PR-Codex overview
Detailed summary
sa-tan
plugin in thepom.xml
file.sa-tan
plugin to setfailOnError
tofalse
.sa-tan
plugin.maven-checkstyle-plugin
.