Clear favicon when the favicon is removed

eoger · Nov 18, 2017 · ffa0ac4 · ffa0ac4
1 parent f7d8a89
commit ffa0ac4
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/src/tab.js b/src/tab.js
@@ -141,9 +141,12 @@ SideTab.prototype = {
     const imgTest = document.createElement("img");
     imgTest.src = favIconUrl;
     imgTest.onerror = () => {
-      this._iconView.style.backgroundImage = "";
+      this.resetIcon();
     };
   },
+  resetIcon() {
+    this._iconView.style.backgroundImage = "";
+  },
   setLoading(isLoading) {
     toggleClass(this.view, "loading", isLoading);
     if (isLoading) {

diff --git a/src/tablist.js b/src/tablist.js
@@ -648,7 +648,11 @@ SideTabList.prototype = {
   setIcon(tab) {
     let sidetab = this.getTab(tab);
     if (sidetab) {
-      sidetab.updateIcon(tab.favIconUrl);
+      if (tab.favIconUrl) {
+        sidetab.updateIcon(tab.favIconUrl);
+      } else {
+        sidetab.resetIcon();
+      }
     }
   },
   setLoading(tab, isLoading) {