This repository has been archived by the owner on Nov 17, 2022. It is now read-only.
Add bottom shadow when we can scroll down (mirror top shadow) #367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ariasuni
force-pushed
the
add-bottom-shadow
branch
from
1e902a4
to
1e5cae8
Compare
|
I found a way to make it work but I need the more tabs button to use a solid color, otherwise it looks broken. What about using Photon colors (from here) instead of most of the actual colors? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add a shadow at the bottom of the tab list when we can scroll down, like it’s the case with the top shadow present when we can scroll up.
However, right now there’s still a problem: when searching among tabs, she shadows shows up on the button «Show all tabs…», and I don’t know how to fix that.